13:01:11 #startmeeting 13:01:11 Meeting started Wed Dec 4 13:01:11 2013 UTC. The chair is alinefm. Information about MeetBot at http://wiki.debian.org/MeetBot. 13:01:11 Useful Commands: #action #agreed #help #info #idea #link #topic. 13:01:18 #meetingname scrum 13:01:18 The meeting name has been set to 'scrum' 13:01:18 hi, danielhb, alinefm, shall we start now? 13:01:39 #info Agenda 1) Sprint 2 2) Open discussion 13:01:43 royce, yes 13:01:48 anything else? 13:02:33 seems not 13:02:53 markwu:gerrit? 13:03:07 it's ok for me 13:03:19 royce, yes, if you have interest 13:03:29 i have sent an email 13:03:55 royce, markwu, I think we can cover it on open discussion section 13:04:03 agree 13:04:16 sure 13:04:28 so let's get started 13:04:31 #topic Sprint 2 13:04:42 https://github.com/kimchi-project/kimchi/wiki/Todo-1.1 13:04:51 gerrit is a platitude. cons and pros between mail-list and gerrit. 13:05:02 the first item is: Basic host management (host) 13:05:16 I've just seen the UI patches related to it on mail list 13:06:06 alinefm: I have test it today. 13:06:06 and in my first tests it seems ready to be merged 13:06:15 alinefm: agree. 13:06:40 what is missing about this item is about: Backend and API to initiate shutdown and reboot 13:06:42 rotru, ^ 13:06:46 any update? 13:07:15 shutdown is a pretty dangerous operation, we should take care. 13:07:27 Also as reboot 13:08:05 alinefm; hi 13:08:12 Also, I think shutdown is not clear enough to me, does it mean power off or machine halt? 13:08:31 ming, power off 13:08:57 power off is more exact than shutdown. 13:08:59 ming, when authorization comes to board those operations will be restricted to admin user 13:09:33 shutdown can be just a halt with power on. 13:09:55 alinefm; ming I modified the patches in order to just allow shutdown/reboot when none vm is in running state 13:10:31 so, for now, admin will have to stop vms manually before stop server 13:10:38 rotru, ok 13:10:59 I would like to implement vms save/restore in the future 13:11:00 rotru, and when will you send the next version to mail list? 13:11:10 IMO, thereis no impediment to reboot/shutdown the host with VM's running. we just need alert the user/sys_adm and save/restore the VMs 13:11:15 rotru, pradeep sent patches for it 13:12:36 rotru, and when will you send the next version to mail list? 13:13:07 alinefm; I am trying to test mock , then patch should be read after 13:13:23 we should save all VM and then shutdown or reboot? 13:13:23 now, maybe should not allow power off if there is a vm is living. 13:13:23 after we support save VM, kimchi can save VMs first and then shutdown. 13:13:23 rotru, do you think it can be done by today? 13:14:09 shaohef, for now, we just reboot and shutdown when no vm is running 13:14:22 shaohef: thanks for your info, i will have to go to the office and talk to my boss. 13:14:22 when we implemente save/restore we can improve it 13:14:29 shaohef, right. The vm user should not notice VM's off and on. 13:14:56 that is our next step 13:15:28 ming, agree 13:15:39 alinefm; ming , shaohef yes! vm shutdown, save, restored will be a improvement in next version 13:15:44 alinefm: agree. 13:15:51 ok 13:15:52 zwu: you are welcome. 13:15:52 ming: yes. 13:16:00 next: Storage: New Storage Pool based on local disk (storage) 13:16:03 danielhb, ^ 13:16:29 I tried your patches yesterday and got some errors 13:16:48 hello 13:16:53 alinefm, errors apparently are fixed now, I'll sending v6 shortly 13:17:05 danielhb, great 13:17:12 alinefm, but I'm tempted to send them to you first to see if they are really working now :) 13:17:35 danielhb, don't be shy to send out to all of us. 13:17:49 We can do more tests. 13:17:57 ming, that's because alinefm's notebook does not like me and keeps crashing my stuff 13:18:03 hehehe 13:18:09 ming, but I'll send them all to you, of course :) 13:18:13 my notebook is terrible =) 13:18:20 alinefm is using unbutu? 13:18:25 I saw zhshzhou commented about using exsited VG 13:18:37 alinefm, yes 13:18:41 ming, yes 13:18:47 zhoumeina, I've seen your patches about the UI for it but I haven't had chance to check it yet 13:18:55 zhoumeina, do you want to comment something about it? 13:19:19 royce, I was going to answer that ... I think this is already supported if you use an existing VG as target while providing no devices in the element 13:19:36 alinefm: yes, in this patch I also changed the nfs style 13:20:15 OK, so provide a VG name can cover that, right? danielhb 13:20:19 royce, but this is a guess based on what I've read on Red Hat documentation on virt-manager (please do not ban me!), need to test it to see if this works 13:20:27 I changed storage pool type to list box 13:20:27 zhoumeina, you made a single window and dynamically show more inputs according to pool type? 13:20:40 alinefm: yes 13:21:17 zhoumeina, ok - I will try them after meeting 13:21:19 danielhb, yes, guess that'll work cause libvirt doc said so too. 13:21:53 next: Add new yum repository (from ISO and from URL) (host) 13:21:55 pvital_, ^ 13:22:13 create storage pool,user will see the "dir" page.when he/she change the storage type, different input can be seen 13:22:53 pvital_, you sent the patches about YUM repo at the begging of the week, any update? 13:22:54 alinefm, I submited this morning a new version to API and backend. It's supporting YUM for now because I found some errors in different versions of python-apt 13:23:38 I'm testing e re-implementing the APT support. 13:23:41 pvital_, are you considering an repo as a ISO file? 13:24:29 alinefm, from ISO I assumed that is already mounted 13:24:41 pvital, I am not understanding how you can use yum update when you don't pass password to RHEL repoitory 13:24:48 so you can use the file:// os mount point 13:25:03 I think all of the RHEL repository are protected by password and user. 13:25:24 ming, epel is not protected 13:25:46 pvital_, ok 13:25:58 pvital_, do you have an idea when apt support will be done? 13:26:39 ming, yes and no! once the sys_adm uses the rhn_reg (or something else) it's not necessary user/password. Yum has the repositories info stores and it'll be reflected in out list 13:26:39 alinefm: I have seen pvital_ add file:// for iso file 13:26:48 pvital_: right? 13:26:59 alinefm, I guess until the end of day 13:27:11 Do you have plan to use offical RHEL repository, like Redhat RHN, LTC ftp3? 13:28:04 ming, I guess we can improve this in later versions. For now I'm supporting only public repositories 13:28:19 Sure, that is clear. 13:28:50 for iso file, will you check it is a valid iso? 13:30:06 ming, what do mean by 'valid iso' ? 13:30:25 bootable? linux content? 13:30:49 For example, the user need to update FC19, but in the host only FC18 iso is mounted. 13:31:32 So the user may input FC18 path for yum. 13:31:49 But that is not what you expected. 13:32:03 ming, no! I'm not checking this kind of info! 13:32:28 So you assume the iso file is right and mounted already. 13:32:40 yes 13:33:18 next? 13:34:19 alinefm, go ahead 13:34:27 ok 13:34:28 Software update (host) 13:34:39 pvital_, you again ^ 13:34:47 alinefm, :-D 13:35:36 alinefm, I have it implemented but need APT support first! then I'm going to test it and submit 13:35:39 softwware update depend on new yum repository? 13:35:50 I guess I can finish this today 13:36:06 alinefm, BTW ramonn implemented the core of this issue! 13:36:09 thanks ramonn 13:36:21 s/issue/feature 13:36:30 ming, no 13:36:42 pvital_, if you need help, just call me 13:36:46 ming, the software update can work with the current repos 13:36:49 Is it not updated by yum or apt? 13:37:07 ming, yes 13:37:25 pvital_, you can include ramonn as signed-off on patches 13:37:35 alinefm, for sure 13:37:45 alinefm, current repos means the default repos coming with the Linux distros? 13:38:09 ming, yes 13:38:22 or other repos admin added manually 13:39:01 alinefm, I guess I got what ming wants to understand. 13:39:15 I did a dependency between these two features 13:39:35 but looking ming questions, I see it can be independents 13:40:21 alinefm, will work with ramonn to send a patch that dont depends on (new) repositories feature 13:40:48 pvital_, it'd be great 13:41:10 pvital_, cool. 13:41:13 ramonn, you have 10min to implement it 13:41:16 :-D 13:41:20 * pvital_ is evil 13:41:30 ok, I think we pass through all the tasks 13:41:35 so we have: 13:42:00 #action rotru send patches about reboot/shutdown to mail list by today 13:42:24 #action pvital_ send patches to yum/apt patches by today 13:42:46 #action pvital_, ramonn send patches to software update by today 13:42:51 is that right? 13:44:00 alinefm; ok 13:44:00 Do you guys get power machines to test Kimchi on power? 13:44:31 alinefm, I don't know how is that pvital_ 13:44:32 :-D 13:44:46 just kidding! to relax a bit! 13:45:04 :) 13:45:06 pvital, =) 13:45:08 ok 13:45:16 then open discussion 13:45:22 #topic Open Discussion 13:45:25 pvital: who is pvital_ ? 13:45:36 shaohef, it is pvital clone =P 13:45:36 gerrit server setup? 13:45:41 ming, sure 13:45:51 I've just read the mail sent by markwu 13:45:54 I think we need a server with public access. 13:46:01 ming, exactly 13:46:03 shaohef, alinefm: and he is evil !!! 13:46:06 shaohef, pvital_ is the IRC client that pvital keeps online inside the Mercedes 13:46:18 It seems that oVirt may host Kimchi gerrit server for us. 13:46:28 ming, at first, I would like to get agreement among our community about the change 13:46:38 and more than that we need to think how it will improve our process 13:46:52 markwu, no one object it yet. 13:46:59 I agree with markwu points about CI and etc 13:47:02 if everyone is fine with this proposal, we can consider to resolve the public server 13:47:09 but my concern is about reviewing itself 13:47:34 markwu, alinefm: let's vote here? 13:47:44 pvital, no 13:47:45 alinefm, anyway, as a tool, gerrit is better than mailling list 13:47:46 let's discuss 13:47:46 alinefm, gerrit record the reviewing process quite well. 13:47:49 =) 13:47:54 alinefm, reviewing it self? 13:47:54 I think adam and anthony do not like gerrit, just because the are used to mail-list. 13:47:54 they use mutt as their mail client. 13:47:54 adam suggests Evolution. 13:47:54 Evolution is better than thunderbird for code review. 13:47:54 also mutt can use vim as it editor. 13:47:55 mutt and Evolution can support highlight. 13:48:15 but most of us use thunderbird 13:48:18 even though gerrit can't resolve all the problems 13:48:36 +1 13:48:42 +1 13:48:49 markwu, when any new patch is sent to gerrit, how all the team is notified? 13:49:24 alinefm, if you need the notification, gerrit can send a mail automatically 13:49:53 markwu, so each you need to configure gerrit to it? 13:49:54 then gerrit can send it to every one? 13:49:57 but according to the experience before, people normally just focus on the dashboard of gerrit 13:49:58 alinefm, it can also be configured to send the notification to the mailing list. 13:50:11 one person will have to be like a Gerrit manager, reviewing all stuff a 13:50:13 yes 13:50:37 actually , alinefm =P 13:50:41 Also, a person can be assigned to the patch to do review. 13:50:42 http://gerrit.ovirt.org/#/q/status:open+project:vdsm,n,z 13:50:47 ming, no 13:50:49 alinefm, we add ourselves as reviewer for mail notification, or we go to website for review 13:50:50 here's an example of gerrit 13:50:58 yes 13:51:12 royce, good point! 13:51:25 cant be the mailling list? 13:51:35 it can get your attention when the patch is updated. 13:51:44 alinefm, a person can be assigned, while others can also do the review. 13:51:54 and you also can add reviewer request on your patch 13:51:59 alinefm, thet is not exclusive. 13:52:02 or a different mailing list, like kimchi-gerrit ot kimchi-dev 13:52:09 I don't understand what't the difference of gerrit review vs what we do in the mailing list ... but we can try using gerrit, of course 13:52:16 normally we use the later one, that is kind of like browsing bbs,quite convinient 13:52:46 pvital, danielhb, difference is we can test others patch easier 13:52:54 it also provides a clear view of patch diff 13:53:00 I was commiter of a open source project called Linuxtools (an Eclipse.org project) and we switched to Gerrit there .... I didn't saw any difference but the extra stuff to do before commit/push 13:53:25 even for differences among revisions of one patch 13:53:47 but, again, let's try gerrit and see if that improves the review process here ... if it doesn't, roll back :) 13:54:47 danielhb, we need to do it carefully 13:54:50 maybe 1 week trial period?:) 13:54:57 I am not convinced it will be good for us 13:54:59 royce: how can we test others patch easier. git pull other's patches? 13:55:15 shahef:git fetch git://gerrit.ovirt.org/ovirt-engine refs/changes/37/20737/20 && git checkout FETCH_HEAD 13:55:32 piece of cake! 13:55:34 :-D 13:55:48 royce: recall it. 13:55:48 it has origin ref for commit change 13:55:58 royce, that is pretty nice for us. 13:56:00 and why not: git am ? 13:56:19 alinefm, you need to downlaod mail-patches first. 13:56:41 and send to some machine it's configured to use mail 13:56:43 ming, there tools to make it for you 13:56:56 alinefm, his patch is diff from his tip, so when applying on your tip, there will be conflict you need to resolve 13:57:00 However, for gerrit, just one command. 13:57:27 alinefm: most of us use thunderbird, thunderbird is not convinient to download patches. 13:57:38 ming, make a script and get it in one command 13:57:47 alinefm, you can to review for openstack, then you will know how it works and love it:) 13:57:58 shaohef, I also use thurderbird and it works weel for me 13:58:17 alinefm, is it friendly for the guys not deeply use linux command lines? 13:58:19 royce, yes - I think I need to try it out to change my view of it 13:58:43 hehheh, OK, after you tried, we can get a conclusion, OK? 13:58:45 markwu, how a non-linux devel will code for linux? 13:58:45 I believe the guys from software group doesn't like that resolution 13:58:46 alinefm: you can share your script 13:58:57 alinefm: linux expert like mail-list, like anthony. most of us are not linux expert 13:59:21 let's do that way 13:59:29 alinefm, are zhoumeina YuXin contributing to kimchi? 13:59:37 I think some people here already tried out gerrit and liked it 13:59:45 others don't like it so much 13:59:53 and others don't try it yet 14:00:18 I can get a conclusion before try it 14:00:31 We won't push~ just have a try and we can help if you have problem with that, OK? 14:00:36 I will install it in my system and check how it works and how it can improve our process 14:00:56 alinefm, you don't need install it on your system 14:01:07 you could just try it with ovirt or openstack 14:01:11 alinefm: but I'm interesting in your thunderbird script. can you share it with us? 14:01:13 it's already there 14:01:31 shaohef, sure 14:01:49 alinefm, how you do a incremental review of patch? 14:01:50 alinefm: great. thanks. 14:01:54 I used patches program from Anthony: https://github.com/aliguori/patches 14:02:44 markwu, what do you mean with incremental review? 14:02:55 V2, V3? 14:03:04 alinefm, actually I don't strongly insist on gerrit for review, but for CI 14:03:08 yep 14:03:09 alinefm: it looks good. 14:03:34 you have to maintain different patches on your local branches 14:03:44 markwu, I agree the CI part is awesome 14:04:16 markwu, but I am wondering if we can get it just using jenkins 14:05:23 alinefm: jenkins can work without gerrit. 14:05:39 shaohef, yes 14:05:45 pvital, any idea? maybe we can write a script to monitor the mailing list , download the patch to test and then post a notification if it fails 14:05:51 I mean if jenkins can cover the CI part done by gerrit 14:06:24 markwu, it's possible 14:06:45 markwu, this script already exists! https://github.com/aliguori/patches 14:06:46 =) 14:06:48 pvital, yes, it's possible. but 14:06:51 hadoop and other apache projects use this approach 14:07:34 ok, then we can follow their practice 14:07:57 hadoop uses jenkins to get the patches (but submitted to a issue tracking system) and test it over trunk/master 14:08:12 can it fetch every post patch or every merged patch? 14:08:16 we can use the same idea 14:08:41 pvital, we should run the test before patch merged 14:09:20 it should be a proof of that the patch is valid for maintainer ( alinefm) 14:09:58 markwu, yeap! 14:10:16 yes 14:10:21 pvital, ok. that's great 14:10:42 look I didn't say NO to gerrit 14:10:57 as I said I will try it to check how it works 14:11:08 then we can discuss in next scrum meeting 14:11:19 ok. actually my concern is we can't request a public server 14:11:38 but for jenkins, we could run in behind IBM firewall 14:12:07 now we are part of ovirt community so we could ask ovirt for it 14:12:09 it's not good, but still work 14:12:17 hope so 14:13:02 ok 14:13:06 #endmeeting